Development #1
Merged
Development #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extracting PollEvent method
…handling and flow control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes refactoring to the
EventPollingclass in thepkg/eventpolling/polling.gofile to improve code readability and maintainability. The main changes involve splitting thePollEventsfunction into two separate functions and removing unnecessary variables.Refactoring for improved readability and maintainability:
pkg/eventpolling/polling.go: Split thePollEventsfunction intoPollEventsandPollEventsUntilEmptyto separate concerns and simplify the control flow. [1] [2]hadMoreThenZeroEventsvariable and adjusted the sleep intervals and loop conditions accordingly. [1] [2]