Skip to content

[BrickSelect] consider all invalid form elements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremy-seipelt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BrickSelect] consider all invalid form elements #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions BrickSelect/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ const BrickSelect = {

this._processOptions();
this._nativeSelect.required = this.hasAttribute('required');

if (!!this.getAttribute('form')) {
Copy link
Contributor

@TitanNano TitanNano Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use hasAttribute here

this._nativeSelect.setAttribute("form",this.getAttribute('form'));
}

this.addEventListener('click', this._onSelectOpened.bind(this));
this.addEventListener('change', this._onSelectionChanged.bind(this));
Expand Down Expand Up @@ -225,9 +229,12 @@ const BrickSelect = {

event.preventDefault();

if (event.target.form.querySelector(':invalid') !== event.target) {
const firstInvalidInput = Array.from(event.target.form.elements)
.find(element => element.matches(':invalid'));

if (firstInvalidInput !== event.target) {
return;
}
}

event.target.parentElement.scrollIntoView({ block: 'center', inline: 'nearest', behavior: 'smooth' });
},
Expand Down