Increased size of nbr in ServoPin_t to enable usage of alternative Pin Mappings#1
Open
tscheskn wants to merge 1 commit intoPR-DC:mainfrom
Open
Increased size of nbr in ServoPin_t to enable usage of alternative Pin Mappings#1tscheskn wants to merge 1 commit intoPR-DC:mainfrom
tscheskn wants to merge 1 commit intoPR-DC:mainfrom
Conversation
…n Mappings e.g. servo.attach(PB0 | ALT1) would fail, also the wrong pin number would be given to HardwareTimer.setMode() later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using alternative Pin Mappings a Mask of 0xN00 is used to get the ALT_N mapping of a pin. This increases the pin number above 256. Therefore the uint8_t that is used in ServoPin_t is to small.
e.g. servo.attach(PB0 | 0x100) would fail, also the wrong pin number would be given to HardwareTimer.setMode() later.
This change has been tested on a Nucleo F446RE with the ALT_1 Mappings on Pins PA1(Timer5), PB0(Timer3), and PB8(Timer4).