Skip to content

Implement variable ordering optimization #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ProgMiner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement variable ordering optimization #181

ProgMiner wants to merge 1 commit into from

Conversation

@ProgMiner
Copy link
Contributor

@ProgMiner ProgMiner commented Jun 23, 2025 •
edited
Loading

Since variables allocated linearly of allocation time, this optimization must increase Var.subst optimization hit rate and shorten Subst.walk recursion paths

@ProgMiner ProgMiner requested a review from Kakadu as a code owner June 23, 2025 20:05
@Kakadu
Copy link
Collaborator

Kakadu commented Jun 24, 2025

Since variables allocated linearly of allocation time, this optimization must increase Var.subst optimization hit rate

I don't really understand how it is related. Var.subst fires depending on the place of fresh logic variable, not on it's value.

Kakadu
Kakadu requested changes Jun 24, 2025
View reviewed changes
regression_ppx/test015.t
11: { 0: [| 11 =/= _.10 |] }
11: { 0: [| 11 =/= boxed 0 <_.12, _.13> |] }
11: { 0: [| 11 =/= _.10 |] }
Copy link
Collaborator

@Kakadu Kakadu Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really correct?

Copy link
Contributor Author

@ProgMiner ProgMiner Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added explanation in the commit message

@ProgMiner
Copy link
Contributor Author

ProgMiner commented Jun 24, 2025

Since variables allocated linearly of allocation time, this optimization must increase Var.subst optimization hit rate

I don't really understand how it is related. Var.subst fires depending on the place of fresh logic variable, not on it's value.

Since we allocate variable numbers linearly, we may assume that variables with greater number was allocated after variables with less number. So, if we have two variables x and y and x.number < y.number, we may assume that y was allocated nearly to the current execution point in source program. So, if x was allocated in the local scope, y must be allocated in the local scope too since it was allocated closer to the current execution point than x. So y will be in local scope with more probability.

@ProgMiner
Implement variable ordering optimization
4d7d0c8 
Since variables allocated linearly of allocation time, this optimization
must increase [Var.subst] optimization hit rate and shorten [Subst.walk]
recursion paths

In "regression_ppx/test015.t" we have change from term to variable
because of swapping sides of disequality in constraint store. As a
result, we doesn't simplify the constraint when variable "10" is
unified.

Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kakadu Kakadu Kakadu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ProgMiner @Kakadu