Skip to content

[visx] do not support every files path #69 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzoghbi merged 2 commits into from
Apr 25, 2026
Merged

[visx] do not support every files path #69 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc35db0
fixed empty space parsing issue in crate path
muhammad-hassnain Apr 25, 2026
2bb5743
✨ cargo fmt + unused cleanup
muhammad-hassnain Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions editor-plugin/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions lang_server/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::{collections::HashMap, error::Error, path::PathBuf, str::FromStr};
use std::{collections::HashMap, error::Error, path::PathBuf};

use anyhow::{anyhow, Context};
use cargo_scan::{
Expand Down Expand Up @@ -105,7 +105,9 @@ fn runner(
.and_then(|folders| folders.first().map(|folder| folder.uri.clone()))
.ok_or_else(|| anyhow!("Couldn't get root path from workspace folders"))?;

let root_crate_path = std::path::PathBuf::from_str(root_uri.path())?;
let root_crate_path = root_uri
.to_file_path()
.map_err(|_| anyhow!("Could not convert root URI to file path"))?;
info!("Crate path received in cargo-scan LSP server: {}", root_crate_path.display());

let scan_res =
Expand Down
Loading