Fixed PHPDoc return type hint for \PHPExif\Exif::getGPS()#90
Closed
jdevinemt wants to merge 1 commit intoPHPExif:masterfrom
Closed
Fixed PHPDoc return type hint for \PHPExif\Exif::getGPS()#90jdevinemt wants to merge 1 commit intoPHPExif:masterfrom
jdevinemt wants to merge 1 commit intoPHPExif:masterfrom
Conversation
The `getGPS()` method in `lib/PHPExif` had a return value of `array|boolean` in the PHPDoc block. The return value should always be a string. `setGPS()` accepts a string, and when the GPS data value is written directly elsewhere in this library, it is also set to a string. This was causing issues during static analysis. I changed the return type in the PHPDoc block to `string|boolean`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getGPS()method inlib/PHPExifhad a return value ofarray|booleanin the PHPDoc block. The return value should always be a string.setGPS()accepts a string, and when the GPS data value is written directly elsewhere in this library, it is also set to a string.This was causing issues during static analysis.
I changed the return type in the PHPDoc block to
string|boolean.