Skip to content

pandas before 3.0.0, fixed separator #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulJonasJost merged 1 commit into from
Mar 16, 2026
Merged

pandas before 3.0.0, fixed separator #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ maintainers = [
description = "Graphical user interface for the PEtab format"
dependencies = [
"pyside6",
"pandas",
"pandas<3.0.0",
"antimony",
"python-libsbml",
"matplotlib",
Expand Down
5 changes: 4 additions & 1 deletion src/petab_gui/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,9 @@ def process_file(filepath, logger):
)
return None, None

# if separator is None:
# separator = "\t"

# Case 3.2: Identify the table type based on header content
if {petab.C.OBSERVABLE_ID, petab.C.MEASUREMENT, petab.C.TIME}.issubset(
header
Expand All @@ -427,7 +430,7 @@ def process_file(filepath, logger):
petab.C.CONDITION_ID in header
or f"\ufeff{petab.C.CONDITION_ID}" in header
):
return "condition", separator
return "condition", separator if separator is not None else "\t"
if petab.C.PLOT_ID in header:
return "visualization", separator
logger.log_message(
Expand Down