[DO NOT MERGE] GoodMem chat plugin for ADK #1
+1,752
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GoodmemChatPlugin for persistent conversation memory using Goodmem.ai service. The plugin automatically logs user messages and LLM responses, retrieves relevant historical context, and augments prompts with memory. Features: - Auto-logging of text messages and file attachments to Goodmem spaces - Context retrieval using semantic search with configurable top-k - Per-user memory isolation with automatic space management - Comprehensive error handling and debug mode - Support for binary attachments (PDFs, images, etc.) File structure: . ├── src/google/adk_community/ │ ├── __init__.py (modified: added plugins import) │ └── plugins/ │ ├── __init__.py (new: module exports) │ └── goodmem.py (new: 736 lines, plugin implementation) │ ├── tests/unittests/ │ └── plugins/ │ ├── __init__.py (new: test module) │ └── test_goodmem.py (new: 31 unit tests, 725 lines) │ ├── contributing/samples/goodmem/ │ ├── README.md (new: overview and setup guide) │ ├── PLUGIN.md (new: detailed plugin documentation) │ └── agent.py (new: sample agent with plugin) │ └── pyproject.toml (modified: added requests dependency) Test coverage: 31/31 tests passing (100%) - 8 tests for GoodmemClient (API operations) - 23 tests for GoodmemChatPlugin (lifecycle, callbacks, error handling) Related: Follows patterns from OpenMemory (PR google#36) and Redis Sessions (PR google#32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT MERGE THIS PR. This PR is for GoodMem team to clearly see what files are changed/added. Later, we will create a formal PR and submitted to google's adk-python-community repo.
GOODMEM TEAM: Please make changes in the
pluginbranch.Add GoodmemChatPlugin for persistent conversation memory using Goodmem.ai
service. The plugin automatically logs user messages and LLM responses,
retrieves relevant historical context, and augments prompts with memory.
Features:
File structure:
Test coverage: 31/31 tests passing (100%)
Related: Follows patterns from OpenMemory (PR google#36) and Redis Sessions (PR google#32)