fix(threats): treat v2 IPS success as authoritative#628
Open
jedis00 wants to merge 1 commit into
Open
Conversation
When ThreatCollectionService polls for IPS events, it calls the v2 system-log endpoint first, then falls back to the v1 stat/ips/event endpoint. The early-return guard in the v2 branch only triggers when the response contains one or more events, so a successful v2 response with zero new events falls through to v1. On UniFi Network 10.2.x the v1 endpoint has been removed and returns 404, which the generic API wrapper logs at ERR level before the outer try/catch can swallow it. Result: one 'API call failed with status NotFound' entry per poll cycle indefinitely on any healthy controller with no new threats in the window. Treat a v2 response with a defined ValueKind as authoritative. The v1 fallback now only runs when v2 itself throws or returns Undefined, which is the original intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ThreatCollectionService polls for IPS events, it calls the v2 system-log endpoint first, then falls back to the v1 stat/ips/event endpoint. The early-return guard in the v2 branch only triggers when the response contains one or more events, so a successful v2 response with zero new events falls through to v1. On UniFi Network 10.2.x the v1 endpoint has been removed and returns 404, which the generic API wrapper logs at ERR level before the outer try/catch can swallow it. Result: one 'API call failed with status NotFound' entry per poll cycle indefinitely on any healthy controller with no new threats in the window.
Treat a v2 response with a defined ValueKind as authoritative. The v1 fallback now only runs when v2 itself throws or returns Undefined, which is the original intent.