Skip to content

[REFACTOR] Rename -core package to -common to remove a source of confusion#520

Open
Victor Schappert (vcschapp) wants to merge 1 commit into
devfrom
core2common
Open

[REFACTOR] Rename -core package to -common to remove a source of confusion#520
Victor Schappert (vcschapp) wants to merge 1 commit into
devfrom
core2common

Conversation

@vcschapp
Copy link
Copy Markdown
Collaborator

@vcschapp Victor Schappert (vcschapp) commented May 12, 2026

Description

As discussed and agreed in the 2026-03-11 / CODING SESH 💻 meeting, this change renames the overture-schema-core package to overture-schema-common.

The purpose of this change is to eliminate a source of confusion caused by overloading the word "core":

  • Since early days, the word "core" has been used in Overture to mean that part of the map and its schema that is of central importance and not peripheral.
  • However, in the overture-schema-core package, the word "core" was being used in a different sense to mean basically shared types that are common to more than one theme schema.

This issue has produced real confusion and consumed many minutes of unproductive discussion in meetings. It is hoped this change will eliminate the confusion going forward.

Reviewer Notes

  • Added Adam Lastowka (@Rachmanin0xFF) as a reviewer because this change may potentially break usage of the Pydantic schema in the data pipeline and the team should have a heads up there.

Related

Testing

$ make check

Signed-off-by: schapper <schapper@amazon.com>
@github-actions
Copy link
Copy Markdown

🗺️ Schema reference docs preview is live!

🌍 Preview https://staging.overturemaps.org/schema/pr/520/schema/index.html
🕐 Updated May 12, 2026 17:52 UTC
📝 Commit 9b6cb69
🔧 env SCHEMA_PREVIEW true

Note

♻️ This preview updates automatically with each push to this PR.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the failing CI check: CodeArtifact has published versions through 1.1.1dev3 (Stephen Epps (@stepps00) and I figured this out while dealing with the staging merge), so the version will need to be bumped past that to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename overture-schema-core package to overture-schema-common

3 participants