Skip to content

Fix small startup bug #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JuanMantica123 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix small startup bug #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/mithril/node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var (
Use: "verify-range",
Short: "Verify a range of slots from snapshot",
PreRunE: func(cmd *cobra.Command, args []string) error {
return initConfigAndBindFlags(cmd)
return initConfigAndBindFlags(cmd, false)
},
Run: func(cmd *cobra.Command, args []string) {
runVerifyRange(cmd, args)
Expand All @@ -45,7 +45,7 @@ var (
Use: "verify-live",
Short: "Catchup and verify live blocks",
PreRunE: func(cmd *cobra.Command, args []string) error {
return initConfigAndBindFlags(cmd)
return initConfigAndBindFlags(cmd, true)
},
Run: func(cmd *cobra.Command, args []string) {
runVerifyLive(cmd, args)
Expand Down Expand Up @@ -159,7 +159,7 @@ func init() {
// initConfigAndBindFlags loads TOML config file (if specified) and binds flags to viper.
// After this runs, config values can be read from either CLI flags or config file,
// with CLI flags taking precedence.
func initConfigAndBindFlags(cmd *cobra.Command) error {
func initConfigAndBindFlags(cmd *cobra.Command, live bool) error {
// Initialize config from file (do NOT bind flags - we handle precedence manually)
if err := config.InitConfig(); err != nil {
return err
Expand Down Expand Up @@ -297,7 +297,7 @@ func initConfigAndBindFlags(cmd *cobra.Command) error {
if blockSource == "" {
blockSource = "rpc" // default
}
if blockSource == "rpc" && len(rpcEndpoints) == 0 {
if blockSource == "rpc" && len(rpcEndpoints) == 0 && live {
return fmt.Errorf("blockSource=rpc but no endpoints were provided")
}
overcastEndpoint = getString("overcast-endpoint", "block.overcast_endpoint")
Expand Down