fix(node-ui): stabilize swm graph coloring#600
Merged
Conversation
| ); | ||
| } | ||
|
|
||
| if (swmAttributionPending) { |
There was a problem hiding this comment.
🔴 Bug: This now blocks the entire SWM graph on the attribution lookup, but useSwmAttributions never aborts or times out its /api/query request. If that request stalls during a daemon restart or slow backend query, swmAttr.loading never clears and the SWM tab becomes permanently blank. Before this PR users could still inspect the graph without attribution colors. Please either render the graph with fallback colors while attribution is pending, or add an abort/timeout path so this placeholder cannot hang forever.
There was a problem hiding this comment.
Codex review produced 4 comment(s) but all targeted lines outside the diff and were dropped. Check the workflow logs for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RdfGraphstyling cannot carry across WM/SWM/VM switches.nodeColors.Related
Files changed
packages/node-ui/src/ui/views/project/components.tsxpackages/node-ui/src/ui/hooks/useSwmAttributions.tspackages/node-ui/test/layer-graph-panel.test.tsTest plan
pnpm --filter @origintrail-official/dkg-node-ui exec vitest run test/layer-graph-panel.test.tspnpm --filter @origintrail-official/dkg-node-ui exec vitest run test/layer-graph-panel.test.ts test/ui-compat.test.ts test/use-memory-entities-live-updates.test.ts test/use-memory-entities-partial.test.tspnpm --filter @origintrail-official/dkg-node-ui run buildpnpm --filter @origintrail-official/dkg-node-ui run build:uigit diff --checkhttp://localhost:9200/ui/with no console errors.Hello World: WM and SWM graph canvases render nonblank; WM→SWM→WM keeps WM slate and does not carry amber back into WM.Note: multi-agent attribution quality remains out of scope for M3 and is still gated for N3/G-Q15.