Skip to content

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Dec 24, 2025

Code Change Checklist

  • Changes to harvest Defender Action
    • Remove harvest of old Convex AMO strategy
    • Remove harvest of Morpho strategies
    • Remove harvest of Holesky native staking strategies
  • Rollup changes
    • Upgrade rollup dependencies
    • Simplified rollup config
    • Add note on using emulated node on arm64 for rollup
  • Removed old validator Actions as they are now replaced by the new compounding staking strategy
  • Add the harvest of the new Morpho OUSD v2 strategy including calling merkleClaim on the new strategy
  • Added deploy script 161 to add MORPHO as a rewards token to the Morpho OUSD v2 strategy

Remove harvest of Morpho strategies
Remove harvest of Holesky native staking strategies
Simplified rollup config
Removed old validator Actions from rollup
Add note on using emulated node on arm64 for rollup
shahthepro
shahthepro previously approved these changes Dec 24, 2025
shahthepro
shahthepro previously approved these changes Dec 24, 2025
"prettier": "2.8.8",
"prettier-plugin-solidity": "1.0.0-beta.17",
"rollup": "4.18.0",
"rollup": "4.54.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have verified that these changes have no known vulnerabilities.

// Morpho Gauntlet Prime USDT
"0xe3ae7c80a1b02ccd3fb0227773553aeb14e32f26",
// Meta Morpho Vault
"0x603CDEAEC82A60E3C4A10dA6ab546459E5f64Fa0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a thought: If we don't want to reference hardhat here we could eventually write a helper function that will go through hardhat deployments and find the address of the deployed contract with a specific name

sparrowDom
sparrowDom previously approved these changes Dec 24, 2025
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naddison36 naddison36 dismissed stale reviews from sparrowDom and shahthepro via a9fd677 December 29, 2025 05:14
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.40%. Comparing base (9db833b) to head (5110f21).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2725      +/-   ##
==========================================
+ Coverage   39.07%   39.40%   +0.32%     
==========================================
  Files         126      126              
  Lines        5789     5789              
  Branches     1537     1537              
==========================================
+ Hits         2262     2281      +19     
+ Misses       3525     3506      -19     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36 naddison36 merged commit 1bf1b14 into master Dec 30, 2025
12 of 17 checks passed
@naddison36 naddison36 deleted the nicka/harvest-update branch December 30, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants