-
Notifications
You must be signed in to change notification settings - Fork 96
Update Defender Actions #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Defender Actions #2725
Conversation
Remove harvest of Morpho strategies Remove harvest of Holesky native staking strategies
Simplified rollup config Removed old validator Actions from rollup Add note on using emulated node on arm64 for rollup
| "prettier": "2.8.8", | ||
| "prettier-plugin-solidity": "1.0.0-beta.17", | ||
| "rollup": "4.18.0", | ||
| "rollup": "4.54.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have verified that these changes have no known vulnerabilities.
contracts/utils/harvest.js
Outdated
| // Morpho Gauntlet Prime USDT | ||
| "0xe3ae7c80a1b02ccd3fb0227773553aeb14e32f26", | ||
| // Meta Morpho Vault | ||
| "0x603CDEAEC82A60E3C4A10dA6ab546459E5f64Fa0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a thought: If we don't want to reference hardhat here we could eventually write a helper function that will go through hardhat deployments and find the address of the deployed contract with a specific name
sparrowDom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a9fd677
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2725 +/- ##
==========================================
+ Coverage 39.07% 39.40% +0.32%
==========================================
Files 126 126
Lines 5789 5789
Branches 1537 1537
==========================================
+ Hits 2262 2281 +19
+ Misses 3525 3506 -19
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code Change Checklist
merkleClaimon the new strategy