Fix issue #17 + add unit tests #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cedric-chedaleux
commented
Aug 22, 2025
cedric-chedaleux
commented
- Add unit tests
- Fix Crash when maxCapSize is set #17
The unit tests binary can be compiled with -DTEST_ENABLED=ON build parameter Signed-off-by: Cedric CHEDALEUX <cedric.chedaleux@orange.com>
cedric-chedaleux
force-pushed
the
cch/fix-issue-17
branch
2 times, most recently
from
affc5dd to
5b0ae44
Compare
The condition to know if file rotation should take place can be accessed in a concurrent manner by 2 or more threads. One thread can enter the if block and open a new file and close the current one while the other thread still tries to write to the current logfile that has been closedl! This leads to segfault. Let's move the mutex before the block to prevent this race condition. Signed-off-by: Cedric CHEDALEUX <cedric.chedaleux@orange.com>
cedric-chedaleux
force-pushed
the
cch/fix-issue-17
branch
4 times, most recently
from
bbe6390 to
06e630a
Compare
Signed-off-by: Cedric CHEDALEUX <cedric.chedaleux@orange.com>
cedric-chedaleux
force-pushed
the
cch/fix-issue-17
branch
2 times, most recently
from
786ac41 to
76672d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.