[#65] Use link accessibility trait for more-details-button instead of button (version 1)
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f `button` (#65) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
force-pushed
the
release-1.x/65-the-more-details-component-should-be-a-link-instead-of-a-button
branch
from
79fead3 to
a7343ff
Compare
pylapp
changed the title
link accessibility trait for more-details-button instead of button (version 1) (#66)link accessibility trait for more-details-button instead of button (version 1)
pylapp
changed the title
link accessibility trait for more-details-button instead of button (version 1)link accessibility trait for more-details-button instead of button (version 1)
There was a problem hiding this comment.
Pull request overview
This PR updates the v1 “more details” control to expose itself to VoiceOver as a link instead of a button, and documents the change in the changelog for the next release.
Changes:
- Adjusts the accessibility traits for the “more details” control in
InformationViewso it is announced as a link (both for theNavigationLinkand the external URL-openingButtonpath). - Adds an “Unreleased” section to the changelog, documenting the fix for issue #65.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/DeclarationAccessibility/View/InformationView.swift | Changes the accessibility traits of the “more details” control, removing the button trait and adding the link trait to better reflect its role for VoiceOver users. |
| CHANGELOG.md | Introduces an Unreleased section and notes that the “more details” component is now exposed as a link instead of a button, referencing issue #65. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#65
Description
Update accessibility traits for v1 to expose detailed button as link with Voice Over
Motivation & Context
Improve a11y and be more compliant with use of web view and web browsers to display detailed page
Types of change
Previews
Checklist
Contribution
Accessibility
Development
Documentation
Checklist (for Core Team only)