Conversation
…f `button` (#65) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
1 task
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility by changing the "more details" component from announcing as a button to announcing as a link in VoiceOver. This better aligns with its behavior of navigating to a URL (either via webview or external browser) and improves compliance with web accessibility standards.
Changes:
- Updated accessibility traits for the "more details" button to use
.isLinkinstead of.isButtonin both navigation paths - Added CHANGELOG entry documenting the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/DeclarationAccessibility/View/InformationView.swift | Modified accessibility traits for both OUDSButton instances (webview and external URL cases) to remove button trait and add link trait |
| CHANGELOG.md | Added entry under Unreleased/Fixed section documenting the accessibility improvement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
link accessibility trait for more-details-button instead of button (version 2) (#65)link accessibility trait for more-details-button instead of button (version 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#65
Description
Update accessibility traits for v2 to expose detailed button as link with Voice Over
Motivation & Context
Improve a11y and be more compliant with use of web view and web browsers to display detailed page
Types of change
Previews
Checklist
Contribution
Accessibility
Development
Documentation
Checklist (for Core Team only)