Skip to content

[#65] Use link accessibility trait for more-details-button instead of button (version 2)#66

Open
pylapp wants to merge 1 commit intodevelopfrom
65-the-more-details-component-should-be-a-link-instead-of-a-button
Open

[#65] Use link accessibility trait for more-details-button instead of button (version 2)#66
pylapp wants to merge 1 commit intodevelopfrom
65-the-more-details-component-should-be-a-link-instead-of-a-button

Conversation

@pylapp
Copy link
Member

@pylapp pylapp commented Jan 28, 2026

Related issues

#65

Description

Update accessibility traits for v2 to expose detailed button as link with Voice Over

Motivation & Context

Improve a11y and be more compliant with use of web view and web browsers to display detailed page

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design, a11Y, Q/A review have been done
  • Documentation has been updated if relevant
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

…f `button` (#65)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp self-assigned this Jan 28, 2026
@pylapp pylapp requested a review from pya35 as a code owner January 28, 2026 14:50
@pylapp pylapp linked an issue Jan 28, 2026 that may be closed by this pull request
1 task
@pylapp pylapp added the v2 Version 2.x must be updated or is related to this issue label Jan 28, 2026
@pylapp pylapp requested a review from Copilot January 28, 2026 14:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves accessibility by changing the "more details" component from announcing as a button to announcing as a link in VoiceOver. This better aligns with its behavior of navigating to a URL (either via webview or external browser) and improves compliance with web accessibility standards.

Changes:

  • Updated accessibility traits for the "more details" button to use .isLink instead of .isButton in both navigation paths
  • Added CHANGELOG entry documenting the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Sources/DeclarationAccessibility/View/InformationView.swift Modified accessibility traits for both OUDSButton instances (webview and external URL cases) to remove button trait and add link trait
CHANGELOG.md Added entry under Unreleased/Fixed section documenting the accessibility improvement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pylapp pylapp changed the title Use link accessibility trait for more-details-button instead of button (version 2) (#65) [#65] Use link accessibility trait for more-details-button instead of button (version 2) Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Version 2.x must be updated or is related to this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "more details" component should be a link instead of a button

1 participant