Update badge icon 1.3.0#3576
Draft
hannahiss wants to merge 10 commits into
Draft
Conversation
github-project-automation
Bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
❌ Deploy Preview for boosted failed. Why did it fail? →
|
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the badge-icon component to align with the newer design tokens (system tokens 2.4.0) and the “Update badge - icon 1.3” spec, including new icon assets and additional supported sizes.
Changes:
- Added xsmall and small size variants for badge-icon documentation and styling.
- Reworked functional status badge-icon rendering to use new SVG mask assets (including a two-layer warning icon) and updated padding tokens.
- Added new badge icon SVG token assets per brand and updated Bundlewatch thresholds to reflect the CSS size increase.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/content/docs/components/badges.mdx | Updates badge-icon docs/examples for new sizes and disabled/variant states. |
| scss/_badges.scss | Refactors badge-icon styling (new size vars, status variant mixin, mask-based icons). |
| packages/sosh/scss/tokens/_composite.scss | Adds new badge icon SVG assets (positive/info/warning/negative). |
| packages/orange/scss/tokens/_composite.scss | Adds new badge icon SVG assets (positive/info/warning/negative). |
| packages/orange-compact/scss/tokens/_composite.scss | Adds new badge icon SVG assets (positive/info/warning/negative). |
| .bundlewatch.config.json | Updates max bundle sizes to accommodate CSS growth from new assets/styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+84
to
+92
| &:has(.badge-status-icon) { | ||
| --#{$prefix}badge-color: #{$ouds-color-surface-status-negative-emphasized}; | ||
| --#{$prefix}badge-background-color: #{$ouds-color-content-on-status-negative-emphasized}; | ||
| position: relative; | ||
| display: block; | ||
| flex-shrink: 0; | ||
| width: var(--#{$prefix}badge-size); | ||
| height: var(--#{$prefix}badge-size); | ||
| padding: 0; |
Collaborator
There was a problem hiding this comment.
Righto, idk what was the rationale behind adding display: block here but it works the same without it and works for inline Badge-icon too. So I will delete
Comment on lines
+32
to
+35
| .badge-status-icon::before { | ||
| background-color: currentcolor; | ||
| mask-image: escape-svg($icon); | ||
| } |
Collaborator
There was a problem hiding this comment.
Added mask: no-repeat center / contain;
Comment on lines
306
to
+315
| <span class="badge-status-icon"></span> | ||
| </p> | ||
| <p class="badge badge-positive badge-disabled"> | ||
| <span class="badge-status-icon"></span> | ||
| </p> | ||
| <p class="badge badge-info badge-disabled"> | ||
| <span class="badge-status-icon"></span> | ||
| </p> | ||
| <p class="badge badge-warning badge-disabled"> | ||
| <span class="badge-status-icon"></span> |
Collaborator
There was a problem hiding this comment.
Well, those are disabled so maybe not, then again something is shown... wdyt @hannahiss?
Collaborator
|
I changed the styles of the |
MaxLardenois
approved these changes
May 22, 2026
| Badges - icon are available in four sizes. Add `.badge-xsmall`, `.badge-small`, or `.badge-large` to have the size you want. Default size is medium. | ||
|
|
||
| <Example buttonLabel="badges icon sizes" class="d-flex align-items-center gap-large" code={`<p class="badge"> | ||
| <Example buttonLabel="badges icon sizes" class="d-flex align-items-center gap-large" code={`<p class="badge badge-xsmall"> |
Collaborator
There was a problem hiding this comment.
For small viewports we have an overflow, I propose to only use flex starting at md
Suggested change
| <Example buttonLabel="badges icon sizes" class="d-flex align-items-center gap-large" code={`<p class="badge badge-xsmall"> | |
| <Example buttonLabel="badges icon sizes" class="d-md-flex align-items-center gap-large" code={`<p class="badge badge-xsmall"> |
| { | ||
| "path": "./packages/orange/dist/css/ouds-web.css", | ||
| "maxSize": "65.5 kB" | ||
| "maxSize": "66.75 kB" |
Collaborator
There was a problem hiding this comment.
Oooff, as they say...
boosted-bot
moved this from In Progress / Draft
to Need Lead Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change
Related issues
Closes #3541
Context & Motivation
Tokens update to 2.4.0
Description
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews