Skip to content

feat: useRead#29

Open
puppybits wants to merge 4 commits into
masterfrom
u/bs/useRead
Open

feat: useRead#29
puppybits wants to merge 4 commits into
masterfrom
u/bs/useRead

Conversation

@puppybits
Copy link
Copy Markdown

Description

added useRead and useCache hooks

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

Copy link
Copy Markdown
Member

@comlaterra comlaterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 Just some questions.
Looks awesome!

Comment thread src/hooks/useRead.js Outdated
Comment thread index.d.ts Outdated
Comment thread index.d.ts Outdated
Comment thread index.d.ts
function useRead<Doc extends PathId>(
query: Omit<ReadQuery, 'id'>,
alias: '::alias',
): string;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
): string;
): string | string[];

Comment thread src/hooks/useRead.js Outdated
Comment thread index.d.ts Outdated
Comment thread src/hooks/useRead.js
Comment thread src/hooks/useRead.js
Comment thread src/hooks/useCache.js
Copy link
Copy Markdown

@ralphiz ralphiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation and I like that there are code samples we can follow!

Comment thread index.d.ts Outdated
Comment thread src/hooks/useRead.js Outdated
Co-authored-by: Edmon Marine Clota <comlaterra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants