Add support for holding a button on boot to wait for programmer. #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be useful. |
hecko
reviewed
Dec 22, 2022
|
|
||
| #else | ||
| #error ------------------------------------------- | ||
| #error Unrecognized LED name. Should be like "B5" |
There was a problem hiding this comment.
I think this is incorrect wording probably an effect of cut&paste. Can you re-word please?
Author
There was a problem hiding this comment.
Yeah, I'll change it (and yeah, it's cut and paste).
There's already code that checks for NODATE in optiboot.c, so this just passes the macro definition to the compiler and updates "make help". Signed-off-by: Darsey Litzenberger <dlitz@dlitz.net>
Quit and timeout (will produce an avrdude error) if we try to read EEPROM using a version without EEPROM support.
Author
|
Ugh. Trying to rebase this, I pulled in stuff I didn't mean to. |
WestfW
reviewed
Aug 18, 2025
Member
WestfW
left a comment
WestfW
left a comment
There was a problem hiding this comment.
How difficult would it be for you to have your cosmetic changes (spelling corrections, etc) be in a separate pull request?
Author
|
Not hard at all. I can resubmit the whole thing minus the garbage. On Aug 17, 2025, at 7:06 PM, Bill Westfield ***@***.***> wrote:
@WestfW commented on this pull request.
How difficult would it be for you to have your cosmetic changes (spelling corrections, etc) be in a separate pull request?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this would be useful to other people, but at least the PR can be searched for. Trying to upload to a cricut via PIO or arduino, I kept hitting timeouts, so I added a def for a button which, if held down, causes it to wait forever for programming. The cricut has buttons low when on, but both are supported.
If it's useful, I could probably create #ifdef blocks for the other pins/ports.