fix(builder): scan both node_modules locations for Tailwind classes #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the complex task definition update logic from PR #294. The simple --force-new-deployment is sufficient since the task definition uses :latest tag.
In Docker builds, .npmrc is excluded via .dockerignore, so pnpm's shamefully-hoist=true doesn't apply. Packages install in packages/builder/node_modules/ instead of root. Now scans both locations: - Root node_modules (local dev with shameful hoisting) - Builder's node_modules (Docker builds without .npmrc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken CSS styling in staging where responsive classes (
xl:block,xl:hidden,xl:flex) were missing.Root Cause
In Docker builds,
.npmrcis excluded via.dockerignore. This means pnpm'sshamefully-hoist=truesetting doesn't apply, and packages are installed inpackages/builder/node_modules/instead of the rootnode_modules/.The
@sourcedirectives inindex.cssonly scanned the root location, so Tailwind couldn't find the@openzeppelinpackages containing the responsive classes.Fix
Scan both possible node_modules locations:
Also Reverts
Reverts the complex ECS task definition update logic from PR #294. The simple
--force-new-deploymentis sufficient since the task definition uses:latesttag.Testing
--no-cachexl:block,xl:hidden,xl:flex,xl:flex-col