Skip to content
This repository was archived by the owner on Dec 1, 2023. It is now read-only.

Update docs from transaction flow refactor #334

Merged
ericnordelo merged 19 commits into from
Jan 9, 2023
Merged

Update docs from transaction flow refactor #334

ericnordelo merged 19 commits into from
Jan 9, 2023

Conversation

@ericnordelo
Copy link
Member

@ericnordelo ericnordelo commented Jan 5, 2023 •
edited
Loading

Fixes #333

@ericnordelo ericnordelo linked an issue Jan 5, 2023 that may be closed by this pull request
Update docs from transaction flow refactor #333
Closed
@ericnordelo ericnordelo linked an issue Jan 5, 2023 that may be closed by this pull request
nile run doesn't bubble up script exceptions #335
Closed
@ericnordelo
Copy link
Member Author

ericnordelo commented Jan 8, 2023

I moved Signer back to nile.signer (from nile.core.types.signer) to avoid breaking scripts importing Signer from nile, until we make a proper file structure refactor in #196

andrew-fleming
andrew-fleming reviewed Jan 8, 2023
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Eric! The APIs look 100x better! I left some comments and questions :)

@andrew-fleming andrew-fleming mentioned this pull request Jan 9, 2023
Open
@ericnordelo ericnordelo linked an issue Jan 9, 2023 that may be closed by this pull request
artifacts/ folder missing in base project .gitignore #316
Closed
@ericnordelo ericnordelo mentioned this pull request Jan 9, 2023
Closed
andrew-fleming
andrew-fleming approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go!

@ericnordelo ericnordelo merged commit 70ec135 into OpenZeppelin:main Jan 9, 2023
@ericnordelo ericnordelo deleted the feat/update-docs-#333 branch January 9, 2023 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nile run doesn't bubble up script exceptions Update docs from transaction flow refactor artifacts/ folder missing in base project .gitignore

2 participants

@ericnordelo @andrew-fleming