test(upgradability): integration tests for the CMA #489
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| name: Compact Contracts Integration Suite | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [labeled, synchronize] | ||
| schedule: | ||
| - cron: "0 6 * * *" # nightly at 06:00 UTC | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| run-integration: | ||
| # Run on scheduled/manual triggers, or on PRs carrying the `integration` label. | ||
| if: > | ||
| github.event_name == 'schedule' || | ||
| github.event_name == 'workflow_dispatch' || | ||
| (github.event_name == 'pull_request' && | ||
| contains(github.event.pull_request.labels.*.name, 'integration')) | ||
| name: Run Integration Suite | ||
| runs-on: ubuntu-24.04 | ||
| permissions: | ||
| contents: read | ||
| timeout-minutes: 30 | ||
|
|
||
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@fe104658747b27e96e4f7e80cd0a94068e53901d # v2.16.1 | ||
| with: | ||
| egress-policy: audit | ||
|
|
||
| - name: Check out code | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 2 | ||
|
|
||
| - name: Setup Environment | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Compile contracts | ||
| run: turbo compact --filter=@openzeppelin/compact-contracts | ||
|
|
||
| - name: Start local Midnight stack | ||
| run: make env-up | ||
|
|
||
| - name: Wait for local stack health | ||
| run: | | ||
| for i in $(seq 1 60); do | ||
| if docker compose -f local-env.yml ps --format json | \ | ||
| grep -q '"Health":"healthy"'; then | ||
| echo "Local stack healthy"; exit 0 | ||
| fi | ||
| sleep 5 | ||
| done | ||
| echo "Local stack did not become healthy in time" | ||
| docker compose -f local-env.yml ps | ||
| exit 1 | ||
|
|
||
| - name: Run integration tests | ||
| run: yarn test:integration | ||
|
|
||
| - name: Upload container logs on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: midnight-stack-logs | ||
| path: logs/ | ||
| if-no-files-found: warn | ||
|
|
||
| - name: Tear down local stack | ||
| if: always() | ||
| run: make env-down | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,3 +46,5 @@ coverage | |
| *~ | ||
|
|
||
| *temp | ||
|
|
||
| .claude/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| COMPOSE_FILE := local-env.yml | ||
| LOGS_DIR := logs | ||
| SERVICES := proof-server indexer node | ||
|
|
||
| .PHONY: env-up env-down env-logs env-logs-clean env-status | ||
|
|
||
| ## Start local environment and stream logs to logs/ | ||
| env-up: env-down | ||
| docker compose -f $(COMPOSE_FILE) up -d | ||
| @mkdir -p $(LOGS_DIR) | ||
| @for svc in $(SERVICES); do \ | ||
| docker compose -f $(COMPOSE_FILE) logs -f --no-log-prefix $$svc > $(LOGS_DIR)/$$svc.log 2>&1 & \ | ||
| done | ||
| @echo "Logs streaming to $(LOGS_DIR)/" | ||
|
Comment on lines
+8
to
+14
There was a problem hiding this comment. Wait for the stack to become ready before Line 9 only starts the containers; it does not guarantee that the node, indexer, and proof server are accepting requests yet. Since CI appears to run tests right after 🧰 Tools🪛 checkmake (0.3.2)[warning] 8-8: Target body for "env-up" exceeds allowed length of 5 lines (6). (maxbodylength) 🤖 Prompt for AI Agents |
||
|
|
||
| ## Stop local environment | ||
| env-down: | ||
| @-pkill -f "docker compose -f $(COMPOSE_FILE) logs" 2>/dev/null || true | ||
| docker compose -f $(COMPOSE_FILE) down | ||
|
|
||
| ## Tail all logs | ||
| env-logs: | ||
| tail -f $(LOGS_DIR)/*.log | ||
|
|
||
| ## Clear log files | ||
| env-logs-clean: | ||
| rm -rf $(LOGS_DIR)/*.log | ||
|
|
||
| ## Show container status | ||
| env-status: | ||
| docker compose -f $(COMPOSE_FILE) ps | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Health-check loop exits as soon as ONE service is healthy — tests may fire before the indexer is ready.
grep -q '"Health":"healthy"'succeeds on the first matching line, so the loop exits as soon as any service becomes healthy. Given thatnodehas a 2-second health-check interval andindexeronly starts afternodeis healthy (and then needs its own 10-second health-check cycle), the loop can exit while the indexer is still initialising. Integration tests that hit the indexer endpoint would fail flakily.Pin the loop exit to all three services being healthy:
🛠️ Proposed fix
- name: Wait for local stack health run: | for i in $(seq 1 60); do - if docker compose -f local-env.yml ps --format json | \ - grep -q '"Health":"healthy"'; then - echo "Local stack healthy"; exit 0 + healthy=$(docker compose -f local-env.yml ps --format json \ + | grep -c '"Health":"healthy"' || true) + if [ "$healthy" -ge 3 ]; then + echo "All 3 services healthy"; exit 0 fi sleep 5 done echo "Local stack did not become healthy in time" docker compose -f local-env.yml ps exit 1🤖 Prompt for AI Agents