ERC20 flash mint extension #1608
Conversation
🧪 Cairo Contract Size Benchmark DiffBYTECODE SIZE (felts) (limit: 81,920 felts)No changes in felts. SIERRA CONTRACT CLASS SIZE (bytes) (limit: 4,089,446 bytes)No changes in bytes. This comment was generated automatically from benchmark diffs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 85 85
Lines 2278 2278
=======================================
Hits 2104 2104
Misses 174 174
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
immrsd
left a comment
immrsd
left a comment
There was a problem hiding this comment.
Looking good and consistent with the Solidity implementation!
Left a couple of comments
| /// Forwards to `FeeConfig::flash_fee_receiver`. | ||
| fn _flash_fee_receiver(self: @ComponentState<TContractState>) -> ContractAddress { | ||
| FeeConfig::flash_fee_receiver(self) | ||
| } |
There was a problem hiding this comment.
Do we need this internal trait to wrap calls to the FeeConfig trait?
| ) -> ContractAddress { | ||
| Zero::zero() | ||
| } | ||
| } |
There was a problem hiding this comment.
- Are we going to provide
DefaultFeeConfigimplementation as we usually do? - WDYT about making
max_flash_loanfunction part of the config (and naming itFlashMintConfig)? It will make it much easier to override the implementation if there should be a cap
Fixes #1577
PR Checklist