Skip to content

feat: filter required cap admin pages #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mvdhoek1 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: filter required cap admin pages #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions owc-activity-log.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
const OWC_ACTIVITY_LOG_SETTINGS_KEY = 'owc_activity_log_settings';
const OWC_ACTIVITY_LOG_CRON_HOOK = 'owc_activity_log_cleanup';
const OWC_ACTIVITY_LOG_DEFAULT_RETENTION_DAYS = 30;
const OWC_ACTIVITY_LOG_SETTINGS_PAGE_CAP = 'manage_options';

require_once __DIR__ . '/src/helpers.php';
require_once __DIR__ . '/src/autoload.php';
Expand Down
4 changes: 2 additions & 2 deletions src/Controllers/AdminPageController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class AdminPageController
*/
public function render_log(): void
{
if ( ! current_user_can( 'manage_options' ) ) {
if ( ! current_user_can( settings_page_cap() ) ) {
wp_die( esc_html__( 'You do not have permission to view this page.', 'owc-activity-log' ) );
}

Expand All @@ -60,7 +60,7 @@ public function render_log(): void
*/
public function render_settings(): void
{
if ( ! current_user_can( 'manage_options' ) ) {
if ( ! current_user_can( settings_page_cap() ) ) {
wp_die( esc_html__( 'You do not have permission to view this page.', 'owc-activity-log' ) );
}

Expand Down
6 changes: 3 additions & 3 deletions src/Providers/AdminServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function register_menu(): void
add_menu_page(
__( 'Activity Tracker', 'owc-activity-log' ),
__( 'Activity Log', 'owc-activity-log' ),
'manage_options',
settings_page_cap(),
OWC_ACTIVITY_LOG_SLUG,
$controller->render_log( ... ),
'dashicons-visibility',
Expand All @@ -59,7 +59,7 @@ public function register_menu(): void
OWC_ACTIVITY_LOG_SLUG,
__( 'Activity Log', 'owc-activity-log' ),
__( 'Activity Log', 'owc-activity-log' ),
'manage_options',
settings_page_cap(),
OWC_ACTIVITY_LOG_SLUG,
''
);
Expand All @@ -68,7 +68,7 @@ public function register_menu(): void
OWC_ACTIVITY_LOG_SLUG,
__( 'Settings', 'owc-activity-log' ),
__( 'Settings', 'owc-activity-log' ),
'manage_options',
settings_page_cap(),
OWC_ACTIVITY_LOG_SLUG . '-settings',
$controller->render_settings( ... )
);
Expand Down
10 changes: 10 additions & 0 deletions src/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,13 @@ function owc_activity_log_group_enabled( string $group ): bool

return in_array( $group, $settings['enabled_groups'], true );
}

/**
* @since NEXT
*/
function settings_page_cap(): string
{
$cap = apply_filters( 'owc_activity_log_settings_page_cap', OWC_ACTIVITY_LOG_SETTINGS_PAGE_CAP );

return is_string( $cap ) && '' !== trim( $cap ) ? $cap : OWC_ACTIVITY_LOG_SETTINGS_PAGE_CAP;
}