-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor Vox rake tasks #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| libs.each do |lib, config| | ||
| puts "Checking out #{lib}" | ||
| Vox::Shell.run( | ||
| "git clone --revision #{config[:branch]} #{config[:repo]} #{@deps_tmp}/#{lib}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this actually works with the latest almalinux:9 image. I think they probably updated git in 9.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an AlmaLinux 9.7 VM:
Operating System: AlmaLinux 9.7 (Moss Jungle Cat)
CPE OS Name: cpe:/o:almalinux:almalinux:9::baseos
Kernel: Linux 5.14.0-611.13.1.el9_7.x86_64
Architecture: x86-64
Hardware Vendor: VMware, Inc.
Hardware Model: VMware Virtual Platform
Firmware Version: 6.00
Git Version:
# git --version
git version 2.47.3
90b4798 to
2fbbd39
Compare
|
The rpm/deb packages and the JAR file for openvoxdb are available in a zip archive: |
|
The rpm/deb packages and the JAR file for openvoxdb are available in a zip archive: |
2fbbd39 to
d1cd3f2
Compare
This moves our tasks into the rakelib dir, which is where rake tasks are supposed to live and is automatically loaded, so we don't need a loading line in the Rakefile. This refactors the tasks to extract common methods around running shell commands and running things inside a container. It also significantly reorganizes the build task to make it a bit clearer what each step of the build process is doing.
d1cd3f2 to
a047f2b
Compare
|
The rpm/deb packages and the JAR file for openvoxdb are available in a zip archive: |
|
The rpm/deb packages and the JAR file for openvoxdb are available in a zip archive: |
|
The rpm/deb packages and the JAR file for openvoxdb are available in a zip archive: |
This moves our tasks into the rakelib dir, which is where rake tasks are supposed to live and is automatically loaded, so we don't need a loading line in the Rakefile.
This refactors the tasks to extract common methods around running shell commands and running things inside a container. It also significantly reorganizes the build task to make it a bit clearer what each step of the build process is doing.