Notify now honors withpath parameter#432
Open
acesso wants to merge 1 commit into
Open
Conversation
Notify should not represent a state of a resource since it only "exists" during execution time. This change proposes that it should be considered to always "exist", thus avoiding a change notification. Signed-off-by: Igor Nogueira de Oliveira <igor@acumera.com>
acesso
force-pushed
the
no-duplicate-notify
branch
from
50b9505 to
230960a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Puppet agent with the -t flag, notify resources currently log duplicate messages: one for the explicit message itself, and another for the resource state change (creation/sync). This creates unnecessary log noise, making it harder to spot actual infrastructure changes.
This change modifies the notify resource to always be considered as "existing." By preventing the resource from triggering an out-of-sync event, Puppet will no longer log the redundant state-change notification, resulting in cleaner and more readable execution logs.
The
withpathparameter now makes sense to be used, since the possible need to actually show the resource path.Checklist
I have:
Signed-off-byannotation to each of my commits