Skip to content

Dockerfile: Use leiningen from Debian#323

Open
bastelfreak wants to merge 1 commit into
mainfrom
ruby
Open

Dockerfile: Use leiningen from Debian#323
bastelfreak wants to merge 1 commit into
mainfrom
ruby

Conversation

@bastelfreak
Copy link
Copy Markdown
Contributor

We do not need latest and greatest leiningen. So we don't have to pull it from GitHub. And the Debian apt repo is more trustworthy than pulling a random script with wget from HEAD branch.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

We do not need latest and greatest leiningen. So we don't have to pull
it from GitHub. And the Debian apt repo is more trustworthy than pulling
a random script with wget from HEAD branch.

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@github-actions
Copy link
Copy Markdown

The rpm/deb packages and the JAR file for openvox-server are available in a zip archive:
https://github.com/OpenVoxProject/openvox-server/actions/runs/26180856894/artifacts/7117828571

@nmburgan
Copy link
Copy Markdown
Member

I recently set the min lein version to 2.12 in openvox-server and openvoxdb project.clj. Not sure what the version is in the deb repo. We don't absolutely need the latest, it was just set to very old versions (2.7 or 2.9 or something) that included profile merging bugs which I figured might bite us.

@bastelfreak
Copy link
Copy Markdown
Contributor Author

Debian 12 & 13 only have leiningen 2.10 :( But if there is a minimal version we're below that, the build should fail 🤔 . I will have a look tomorrow.

@corporate-gadfly
Copy link
Copy Markdown
Contributor

If we're wget'ting something at all, ideally we should have pinned versions and/or checksums.

@nmburgan
Copy link
Copy Markdown
Member

Yeah, you'd think it would. Weird. In any case, I think it was 2.9 that had a profile merge bug, so 2.10 is probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants