Don't run dhcpcd command when it isn't running #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmburgan
force-pushed
the
dhcpcd_fix
branch
2 times, most recently
from
17a1e4b to
7d9e8d6
Compare
As noted in puppetlabs/facter#2780, we try running dhcpcd commands when it isn't actually running, which on Ubuntu 24.04 at least ends up with a lot of spam noting this. Additionally, there's really no reason to do this on the loopback interface. This checks in as robust a way as possible to see not only that the dhcpcd command is availabe, but that it's actually running before attempting to run it.
binford2k
reviewed
Jan 13, 2026
binford2k
previously approved these changes
Jan 13, 2026
nmburgan
force-pushed
the
dhcpcd_fix
branch
2 times, most recently
from
7382d6b to
401fad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in puppetlabs/facter#2780, we try running dhcpcd commands when it isn't actually running, which on Ubuntu 24.04 at least ends up with a lot of spam noting this. Additionally, there's really no reason to do this on the loopback interface. This checks in as robust a way as possible to see not only that the dhcpcd command is availabe, but that it's actually running before attempting to run it.