Remove deprecated exec/which exposure from Facter::Util::Resolution#113
Draft
silug wants to merge 1 commit into
Draft
Remove deprecated exec/which exposure from Facter::Util::Resolution#113silug wants to merge 1 commit into
silug wants to merge 1 commit into
Conversation
silug
force-pushed
the
remove-resolution-exec-which
branch
from
46d1772 to
1a9c887
Compare
7 tasks
…bility Remove `Facter::Core::Execution.exec`, which was deprecated in favor of `Facter::Core::Execution.execute` (OpenVoxProject#88). Remove the deprecated class-level `exec`/`which` compatibility exposure from `Facter::Util::Resolution` that bridged to `Facter::Core::Execution` since Facter 2.0.0 (OpenVoxProject#89). These two removals are coupled — `exec` on `Resolution` delegated through `Execution.exec`, so they must ship together. Update the acceptance test that called `Facter::Util::Resolution.exec` to use `Facter::Core::Execution.execute(cmd, on_fail: nil)` directly. Closes OpenVoxProject#88 OpenVoxProject#89 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
silug
force-pushed
the
remove-resolution-exec-which
branch
from
1a9c887 to
fa5f8af
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Remove deprecated Facter::Core::Execution.exec and Resolution compatibility
Remove
Facter::Core::Execution.exec, which was deprecated in favor ofFacter::Core::Execution.execute(#88).Remove the deprecated class-level
exec/whichcompatibility exposure fromFacter::Util::Resolutionthat bridged toFacter::Core::Executionsince Facter 2.0.0 (#89). These two removals are coupled —execonResolutiondelegated throughExecution.exec, so they must ship together.Update the acceptance test that called
Facter::Util::Resolution.execto useFacter::Core::Execution.execute(cmd, on_fail: nil)directly.Closes #88 #89
Checklist
I have:
Signed-off-byannotation to each of my commits