proto: correct 802.1Q length check in is_ipv_X#1044
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TAP mode is_ipv_X() checks an 802.1Q frame against the untagged Ethernet header size but then advances past the larger 18-byte 802.1Q header. A tagged frame of 34 to 37 bytes passes the check yet leaves fewer than sizeof(struct openvpn_iphdr) bytes at the new buffer head, so callers such as client_nat_transform that trust the return value access bytes past the IP header. Use sizeof(struct openvpn_8021qhdr) for the check instead.