(WIP) feature/CPC-12213-update-pod-to-spm#28
Draft
brianinatinyhome wants to merge 1 commit into
Draft
Conversation
brianinatinyhome
changed the title
Contributor
|
Hello @brianinatinyhome check out this PR from the source forked repo i made for RTCMTLVideoView, it use RTC_SUPPORTS_METAL to support also non Metal devices. https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/427/changes |
hthetiot
reviewed
May 29, 2026
| let sdpSemanticsConfig = pcConfig?.object(forKey: "sdpSemantics") as? String; | ||
| let sdpSemantics = (sdpSemanticsConfig != nil && allowedSdpSemantics[sdpSemanticsConfig!] != nil) ? | ||
| allowedSdpSemantics[sdpSemanticsConfig!] : RTCSdpSemantics.planB | ||
| allowedSdpSemantics[sdpSemanticsConfig!] : RTCSdpSemantics.unifiedPlan |
Contributor
There was a problem hiding this comment.
Good catch was already fixed in iosrtc.
https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/fd7e3931d698b1c181619b8ca94d88b3b016d514/src/PluginRTCPeerConnectionConfig.swift#L44
hthetiot
reviewed
May 29, 2026
| class iRTCPeerConnectionConfig { | ||
|
|
||
| fileprivate let allowedSdpSemantics = [ | ||
| "plan-b": RTCSdpSemantics.planB, |
Contributor
There was a problem hiding this comment.
I would still allow it to support old webrtc api usage. We kept it in iosrtc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item Tracking
Jira link: https://combinedpublic.atlassian.net/browse/CPC-12213
Description
This PR changes the WKWebViewRTC Library to be compatible with SPM
Test Plan
Further Comments
None.