Run UI tests with both renderers#877
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 26.94% 26.93% -0.02%
==========================================
Files 678 678
Lines 47146 47146
==========================================
- Hits 12705 12700 -5
- Misses 34441 34446 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: CI UI tests now run in both renderer modes to keep coverage for SwiftUI-backed and OpenSwiftUI-backed rendering. Key changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| xcode-version: ["16.4"] | ||
| release: [2024] | ||
| ios-version: ["18.5"] | ||
| renderer: |
There was a problem hiding this comment.
With renderer added as a matrix axis, this matrix still relies on an include entry that doesn’t specify renderer; that can produce an extra job where matrix.renderer.* is unset (and/or leave the base combinations without ios-simulator-name). Consider ensuring every generated matrix row defines both ios-simulator-name and renderer.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| public static var allCases: [ViewRendererVendor] { [.osui, .sui] } | ||
| } | ||
| public let viewRendererVendor = ViewRendererVendor.sui | ||
| #endif |
There was a problem hiding this comment.
viewRendererVendor is only defined in this #else compilation branch and is currently hard-coded to .sui; the new .disabled(if: viewRendererVendor == .osui, ...) suite annotations may fail to compile or behave incorrectly when the other branch is active now that CI runs both renderer modes.
Severity: high
Other Locations
Example/OpenSwiftUIUITests/Layout/Stack/ZStackIndexUITests.swift:11Example/OpenSwiftUIUITests/Render/GeometryEffect/Rotation3DEffectUITests.swift:10Example/OpenSwiftUIUITests/Render/GeometryEffect/RotationEffectUITests.swift:10Example/OpenSwiftUIUITests/Render/RendererEffect/BlurEffectUITests.swift:10Example/OpenSwiftUIUITests/Render/RendererEffect/ClipEffectUITests.swift:10
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Agent Summary
This draft PR updates UI test coverage so CI exercises both renderer modes.
Changes:
OPENSWIFTUI_SWIFTUI_RENDERERthrough the renderer matrix.Validation:
git diff --check HEAD^ HEAD.github/workflows/uitests.ymlas YAML locally