-
Notifications
You must be signed in to change notification settings - Fork 58
Add ShapeStyledDisplayList support #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Augment PR SummarySummary: This PR starts wiring up display-list rendering for shape-styled leaf views, including initial (WIP) support for interpolator-backed layers. Changes:
Technical Notes: Many entry points are intentionally marked WIP via 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return displayList | ||
| case let .items(items): | ||
| let displayList = DisplayList(items) | ||
| _openSwiftUIUnimplementedFailure() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RenderedLayers.commit currently calls _openSwiftUIUnimplementedFailure() for the .items case, which looks reachable whenever the shape produces multiple layers (e.g. background + foreground when V.hasBackground == true, like Image.Resolved). That means display-list generation can trap at runtime in normal rendering paths.
🤖 Was this useful? React with 👍 or 👎
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
===========================================
- Coverage 28.12% 14.00% -14.13%
===========================================
Files 603 577 -26
Lines 36955 34341 -2614
===========================================
- Hits 10394 4809 -5585
- Misses 26561 29532 +2971 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Image will render on screen. But the containerPosition is not correct.