Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 18, 2026

Image will render on screen. But the containerPosition is not correct.

struct AsyncImageExample: View {
    var body: some View {
        AsyncImage(url: URL(string: "https://picsum.photos/200"))
    }
}
image

@Kyle-Ye Kyle-Ye linked an issue Jan 18, 2026 that may be closed by this pull request
@augmentcode
Copy link

augmentcode bot commented Jan 18, 2026

🤖 Augment PR Summary

Summary: This PR starts wiring up display-list rendering for shape-styled leaf views, including initial (WIP) support for interpolator-backed layers.

Changes:

  • Expanded DisplayList.InterpolatorGroup from an empty stub to a structured (still WIP) type and added placeholder ORB-related display-list types.
  • Updated RendererEffect to construct GeometryProxy with a stable owner identifier and a safer UInt32 seed conversion.
  • Implemented a new ShapeStyledDisplayList update path that builds a DisplayList from a view’s foreground/background shapes and style pack.
  • Introduced _ShapeStyle_RenderedShape and _ShapeStyle_RenderedLayers infrastructure to assemble styled items, effects, and (future) interpolator layers.
  • Refined _ShapeStyle_LayerID typing and began integrating _ShapeStyle_InterpolatorGroup with DisplayList.InterpolatorGroup.

Technical Notes: Many entry points are intentionally marked WIP via _openSwiftUIUnimplementedWarning()/Failure() while the rendering and interpolator plumbing is brought online.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

return displayList
case let .items(items):
let displayList = DisplayList(items)
_openSwiftUIUnimplementedFailure()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RenderedLayers.commit currently calls _openSwiftUIUnimplementedFailure() for the .items case, which looks reachable whenever the shape produces multiple layers (e.g. background + foreground when V.hasBackground == true, like Image.Resolved). That means display-list generation can trap at runtime in normal rendering paths.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 0% with 230 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.00%. Comparing base (11fafa7) to head (4793eb4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tUICore/Shape/ShapeStyle/ShapeStyleRendering.swift 0.00% 158 Missing ⚠️
...tUICore/Shape/ShapeStyle/ShapeStyledLeafView.swift 0.00% 66 Missing ⚠️
...enSwiftUICore/Render/DisplayList/DisplayList.swift 0.00% 4 Missing ⚠️
...tUICore/Render/RendererEffect/RendererEffect.swift 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (11fafa7) and HEAD (4793eb4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (11fafa7) HEAD (4793eb4)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #732       +/-   ##
===========================================
- Coverage   28.12%   14.00%   -14.13%     
===========================================
  Files         603      577       -26     
  Lines       36955    34341     -2614     
===========================================
- Hits        10394     4809     -5585     
- Misses      26561    29532     +2971     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit e34a6a5 into main Jan 18, 2026
5 of 11 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/shape_style branch January 18, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Image support

2 participants