Skip to content

Conversation

@Dark-Existed
Copy link
Contributor

Fix #724

@augmentcode
Copy link

augmentcode bot commented Jan 17, 2026

🤖 Augment PR Summary

Summary: Fixes a bug in AnimatorState.removeListeners() where logical listeners were never notified of animation removal.

Changes:

  • Replaced an accidental second notification of `listeners` (after it was cleared) with a notification of `logicalListeners`, then clears them.

Technical Notes: Addresses #724 by ensuring both listener collections receive animationWasRemoved() exactly once during cleanup.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 14.33%. Comparing base (0d222b7) to head (af853b8).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ore/Animation/Animatable/AnimatableAttribute.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   14.29%   14.33%   +0.03%     
==========================================
  Files         563      573      +10     
  Lines       33189    33640     +451     
==========================================
+ Hits         4744     4821      +77     
- Misses      28445    28819     +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit b75c799 into OpenSwiftUIProject:main Jan 17, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withAnimation completion callback is not invoked

2 participants