Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 11, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 11, 2026

🤖 Augment PR Summary

Summary: This PR updates OpenSwiftUI’s Image API surface to better match audited SwiftUI behavior (6.5.4), laying groundwork for future Image resolution.

Changes:

  • Added CGImage-backed Image initializers (labeled and decorative) via a new CGImageProvider.
  • Introduced platform representation hooks for resolved images and named images (PlatformImageRepresentable/PlatformNamedImageRepresentable) stored in view/graph inputs.
  • Added Image.Interpolation plus interpolation(_:) and antialiased(_:) modifiers (currently WIP providers).
  • Added resizable(capInsets:resizingMode:), ResizingInfo, and protobuf encoding/decoding for resizing state.
  • Defined a placeholder Image.Resolved struct and kept Image.NamedResolved as a stub for ongoing implementation.

Technical Notes: Several providers are intentionally blocked on Image.Resolved and contain unimplemented resolution paths, while protobuf mappings are defined for persistence/archiving.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 0% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.39%. Comparing base (d0249df) to head (0a35069).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ces/OpenSwiftUICore/View/Image/ImageResizing.swift 0.00% 41 Missing ⚠️
...penSwiftUICore/View/Image/ImageInterpolation.swift 0.00% 39 Missing ⚠️
...s/OpenSwiftUICore/View/Image/CGImageProvider.swift 0.00% 26 Missing ⚠️
...Core/View/Image/Image+PlatformRepresentation.swift 0.00% 10 Missing ⚠️
Sources/OpenSwiftUICore/View/Image/Image.swift 0.00% 1 Missing ⚠️
...ources/OpenSwiftUICore/View/Image/NamedImage.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   14.46%   14.39%   -0.08%     
==========================================
  Files         565      571       +6     
  Lines       33335    33507     +172     
==========================================
+ Hits         4822     4823       +1     
- Misses      28513    28684     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/view/image2 branch from ea1df81 to 20c079b Compare January 11, 2026 20:22
@Kyle-Ye Kyle-Ye force-pushed the feature/view/image2 branch from 20c079b to 0a35069 Compare January 11, 2026 20:36
@Kyle-Ye Kyle-Ye merged commit eece8ed into main Jan 11, 2026
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/view/image2 branch January 11, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants