feat: : Add a formatter for entities related to speaker presentations. #466
Conversation
matiasperrone-exo
changed the title
andrestejerina97
changed the title
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
3 times, most recently
from
7a0f72c to
196c76c
Compare
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
DRY suggestion: Refactor to deduplicate the getUserInfo() function that's copied in multiple formatter classes. Suggest moving it to AbstractAuditLogFormatter
| $this->event_type = $event_type; | ||
| } | ||
|
|
||
| private function getUserInfo(): string |
There was a problem hiding this comment.
@andrestejerina97 move this to AbstractAuditLogFormatter and remove dupe code
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
|
|
||
| switch ($this->event_type) { | ||
| case IAuditStrategy::EVENT_ENTITY_CREATION: | ||
| $submission_dates = $subject->getSubmissionBeginDate() && $subject->getSubmissionEndDate() |
There was a problem hiding this comment.
@andrestejerina97 use SelectionPlan::hasSelectionPeriodDefined helper method here
| $plan_name = $selection_plan ? $selection_plan->getName() : 'Unknown Plan'; | ||
|
|
||
| switch ($this->event_type) { | ||
| case IAuditStrategy::EVENT_ENTITY_CREATION: |
There was a problem hiding this comment.
@andrestejerina97 this logic is not quite rite , a presentation could be created from show admin itself
in order to apply this strategy u need to check that endpoint being called is
POST api/v1/summits/{id}/presentations
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
d4d163c to
6b32c8b
Compare
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
6b32c8b to
8d57aeb
Compare
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
8d57aeb to
0065fe8
Compare
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
0065fe8 to
9b97589
Compare
ref: https://app.clickup.com/t/86b7n0xv4