feat : Add PresentationTrackChairFormatter #464
Merged
+342
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrestejerina97
force-pushed
the
feature/presentation-track-chair-formatter
branch
4 times, most recently
from
ffe4011 to
66f0a79
Compare
caseylocker
reviewed
Dec 4, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
DRY suggestion: Refactor to deduplicate the getUserInfo() function that's copied in 3 formatter classes.
smarcet
reviewed
Dec 4, 2025
| $this->event_type = $event_type; | ||
| } | ||
|
|
||
| private function getUserInfo(): string |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 move this to AbstractAuditLogFormatter and remove dupe method
smarcet
requested changes
Dec 4, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review
Contributor
Author
|
Improvements to the code incorporated |
andrestejerina97
force-pushed
the
feature/presentation-track-chair-formatter
branch
from
b1416bd to
d881fcf
Compare
feat: add the user context to the formatters
andrestejerina97
force-pushed
the
feature/presentation-track-chair-formatter
branch
from
d881fcf to
22e219b
Compare
andrestejerina97
added a commit
that referenced
this pull request
Dec 16, 2025
This reverts commit eb3a048.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b7n0xv4