-
Notifications
You must be signed in to change notification settings - Fork 2
Feature Extend Swagger Coverage for controller OAuth2SummitTrackChairScoreTypesApiController
#406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Extend Swagger Coverage for controller OAuth2SummitTrackChairScoreTypesApiController
#406
Conversation
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo Quick fix...
Per project conventions, the key should be 'required-groups'.
x: [
'authz_groups' => [ // Wrong key name
IGroup::SuperAdmins,
...
]
],
Should be:
x: [
'required-groups' => [ // Correct key name
IGroup::SuperAdmins,
...
]
],
9a0aff2 to
807dea7
Compare
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent x: Parameter Key
'required-groups' is correct and is used once here.
'authz_groups' is incorrect and is used 4 times here.
Change all:
x: [
'authz_groups' => [
//...
]
],
To
x: [
'required-groups' => [
//...
]
],
807dea7 to
ba84f9c
Compare
|
@caseylocker done! please review |
26b1624 to
2385dd6
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task:
Ref: https://app.clickup.com/t/86b6wkh7x