-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Extend Swagger Coverage for controller OAuth2SummitSubmissionInvitationApiController
#404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend Swagger Coverage for controller OAuth2SummitSubmissionInvitationApiController
#404
Conversation
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo Quick fix:
Wrong Namespace in Security Schema
File: app/Swagger/Security/SummitSubmissionInvitationsAuthSchema.php
namespace App\Swagger\Security; // WRONG
Should be:
namespace App\Swagger\schemas; // CORRECT
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have been a change request...
@matiasperrone-exo Quick fix:
Wrong Namespace in Security Schema
File: app/Swagger/Security/SummitSubmissionInvitationsAuthSchema.php
namespace App\Swagger\Security; // WRONG
Should be:
namespace App\Swagger\schemas; // CORRECT
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the same issue as a previous one in regards to OpenAPI 3.1 functionality being used in a 3.0 project in regards to the "tags" property.
SummitSpeakersSchemas.php:25 - Invalid OpenAPI 3.0 syntax:
items: new OA\Items(type: ['integer', 'string']),
Use oneOf format or change to a single type and document the expansion.
09fe403 to
6668141
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new upgrade to OpenAPI 3.1, allowing type arrays, this should be good to go.
6668141 to
270bcec
Compare
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task:
Ref: https://app.clickup.com/t/86b6wkh7n