Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 14, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 14, 2025
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 18, 2025
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo Quick fix:
Wrong Namespace in Security Schema
File: app/Swagger/Security/SummitSubmissionInvitationsAuthSchema.php
namespace App\Swagger\Security; // WRONG
Should be:
namespace App\Swagger\schemas; // CORRECT

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been a change request...

@matiasperrone-exo Quick fix:
Wrong Namespace in Security Schema
File: app/Swagger/Security/SummitSubmissionInvitationsAuthSchema.php
namespace App\Swagger\Security; // WRONG
Should be:
namespace App\Swagger\schemas; // CORRECT

@matiasperrone-exo
Copy link
Contributor Author

Thanks @caseylocker for the comments. Now is ready to review again

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same issue as a previous one in regards to OpenAPI 3.1 functionality being used in a 3.0 project in regards to the "tags" property.

SummitSpeakersSchemas.php:25 - Invalid OpenAPI 3.0 syntax:
items: new OA\Items(type: ['integer', 'string']),

Use oneOf format or change to a single type and document the expansion.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitsubmissioninvitationapicontroller branch 2 times, most recently from 09fe403 to 6668141 Compare December 4, 2025 20:40
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new upgrade to OpenAPI 3.1, allowing type arrays, this should be good to go.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitsubmissioninvitationapicontroller branch from 6668141 to 270bcec Compare December 5, 2025 14:59
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 9a3ebeb into main Dec 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants