Skip to content

Conversation

@andrestejerina97
Copy link
Contributor

@andrestejerina97 andrestejerina97 commented Oct 14, 2025

@andrestejerina97 andrestejerina97 self-assigned this Oct 31, 2025
@andrestejerina97 andrestejerina97 changed the title feat: Add openapi documentation for SummitAdministratorPermissionGroup Feature | Add openapi documentation for SummitAdministratorPermissionGroup Oct 31, 2025
@andrestejerina97 andrestejerina97 force-pushed the feature/add-summit-administrator-permission-swagger branch from 4b586da to e476b84 Compare November 3, 2025 18:19
@andrestejerina97 andrestejerina97 force-pushed the feature/add-summit-administrator-permission-swagger branch from e476b84 to af9823b Compare November 11, 2025 16:15
@andrestejerina97 andrestejerina97 marked this pull request as ready for review November 11, 2025 18:09
@andrestejerina97 andrestejerina97 added the documentation Improvements or additions to documentation label Nov 11, 2025
@andrestejerina97 andrestejerina97 force-pushed the feature/add-summit-administrator-permission-swagger branch 2 times, most recently from bc3a5d2 to dfa0eeb Compare November 13, 2025 12:23
@smarcet smarcet requested review from Copilot and smarcet November 13, 2025 13:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds OpenAPI documentation for the SummitAdministratorPermissionGroup API endpoints, including schemas for CRUD operations and relationship management (adding/removing members and summits).

Key changes:

  • Added comprehensive OpenAPI schemas for SummitAdministratorPermissionGroup entities and operations
  • Added OAuth2 security scheme definition for summit administrator groups
  • Documented all API endpoints including GET, POST, PUT, and DELETE operations with request/response definitions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
app/Swagger/SummitAdministratorPermissionGroupSchemas.php Defines OpenAPI schemas for SummitAdministratorPermissionGroup, including the main entity schema, create/update request schemas, and paginated list response schema
app/Swagger/Security/SummitAdminGroupsOauth2.php Defines OAuth2 security scheme for summit administrator group endpoints with read and write scopes
app/Http/Controllers/Apis/Protected/Main/OAuth2SummitAdministratorPermissionGroupApiController.php Adds OpenAPI annotations to all controller methods documenting endpoints, parameters, request bodies, responses, and security requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OpenStackweb OpenStackweb deleted a comment from Copilot AI Nov 13, 2025
@OpenStackweb OpenStackweb deleted a comment from Copilot AI Nov 13, 2025
@OpenStackweb OpenStackweb deleted a comment from Copilot AI Nov 13, 2025
@OpenStackweb OpenStackweb deleted a comment from Copilot AI Nov 13, 2025
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrestejerina97 please do rebase with main ( i found an issue on http verbs at main ) and review the comments

@andrestejerina97 andrestejerina97 force-pushed the feature/add-summit-administrator-permission-swagger branch from dfa0eeb to 0029ae5 Compare November 13, 2025 15:47
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 7f96355 into main Nov 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants