-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SummitBadgesApiController
#380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
104b8ac to
60766b8
Compare
OAuth2SummitBadgesApiController
a73e642 to
0f536ac
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'oauth2_security_scope' issue again. Needs to be defined in schemas.php.
response description of "not found" needs to be title case in the controller, "Not Found":
new OA\Response(response: Response::HTTP_NOT_FOUND, description: "Not Found"),
d1f67e8 to
e0522af
Compare
@caseylocker the suggested Title Case is now implemented |
6f7be97 to
1f3f9aa
Compare
|
@caseylocker The security schema for the controller was moved to its own file |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone
Please include a unique operationId to endpoints. It's generally not required but is a good standard to follow for automated tooling.
Fix invalid Object references. You can test this in the generate docs. These are invalid types:
new OA\Property(property: 'ticket', type: 'Ticket'),
new OA\Property(property: 'type', type: 'BadgeType'),
Use ref for these since we're going 1 level deep for nesting here or just use the id declarations and and mark the expandable ones as nullable.
Fix the title casing in the controller error response for:
new OA\Response(response: Response::HTTP_NOT_FOUND, description: "not found"),
It should be title case = "Not Found"
Fix the confusing owner_email filter example:
items: new OA\Items(type: 'string', example: 'owner_email=@example.com')
I know what you're saying here but "=@" means "starts with".
Use "contains" instead if you want to keep the format so: owner_email@@example.com"
Or "starts with": "owner_email=@john"
|
@caseylocker all the requested changes were introduced. Please review it again. |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo We're on a roll. Looks good. @smarcet if you agree please merge.
|
@matiasperrone please review conlficts |
…rformance chore: add needed IDX
…uth2SummitBadgesApiController.php
75b02ef to
744ca2e
Compare
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task:
Ref: https://app.clickup.com/t/86b6wkh3h