-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeFeatureTypeApiController
#376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1693f45 to
767935c
Compare
b65b22d to
e128e9c
Compare
e128e9c to
d3e4f3d
Compare
OAuth2SummitBadgeFeatureTypeApiController
e8f95c9 to
610452a
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the same issue with 'oauth2_security_scope' as mentioned in others. It's a security scope that is not defined, and needs to be, in app/Swagger/schemas.php.
2d4af5e to
12b8784
Compare
@caseylocker thanks, all the changes are now implemented |
…uth2SummitBadgeFeatureTypeApiController.php - fix: Typo seet_type should be seat_type in RSVPAdminAddRequest schema
9ba612a to
e77db3b
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone Very close.
None of the endpoints have operationId defined. Add:
GET all: operationId: 'getAllBadgeFeatureTypes'
GET one: operationId: 'getBadgeFeatureType'
POST: operationId: 'createBadgeFeatureType'
PUT: operationId: 'updateBadgeFeatureType'
DELETE: operationId: 'deleteBadgeFeatureType'
POST image: operationId: 'addBadgeFeatureTypeImage'
DELETE image: operationId: 'deleteBadgeFeatureTypeImage'
That should do it.
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo Looks good. @smarcet if you agree please merge.
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task:
Ref: https://app.clickup.com/t/86b6wkh3f
Aditional Notes