Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 2, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 7, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2speakerorganizationalroleapicontroller branch from 7bc8497 to 0ee2cbb Compare October 8, 2025 21:58
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller Apis/Protected/Summit/OAuth2SpeakerOrganizationalRoleApiController.php Feature | Extend Swagger Coverage for controller OAuth2SpeakerOrganizationalRoleApiController Oct 13, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2speakerorganizationalroleapicontroller branch from 21a81d7 to 4a38e3c Compare October 14, 2025 17:19
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add security: [['summit_rsvp_oauth2' => [...]]] parameter
  2. Remove "Public endpoint accessible without authentication" from description

This endpoint requires OAuth2 authentication with ReadSummitData or ReadAllSummitData scope, it extents OAuth2ProtectedController.

@matiasperrone-exo
Copy link
Contributor Author

  1. Add security: [['summit_rsvp_oauth2' => [...]]] parameter
  2. Remove "Public endpoint accessible without authentication" from description

This endpoint requires OAuth2 authentication with ReadSummitData or ReadAllSummitData scope, it extents OAuth2ProtectedController.

@caseylocker thanks! all the changes are now implemented.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2speakerorganizationalroleapicontroller branch from 444ac99 to fd34d49 Compare November 7, 2025 20:59
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2speakerorganizationalroleapicontroller branch from 6c1ec6f to eed533d Compare November 11, 2025 21:44
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 18, 2025
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo This looks good. @smarcet, if you agree please merge.

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
Copy link
Collaborator

smarcet commented Dec 3, 2025

@matiasperrone please resolve conflicts

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2speakerorganizationalroleapicontroller branch from 38a4325 to b01de04 Compare December 3, 2025 18:29
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit bd563c4 into main Dec 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants