-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SpeakerOrganizationalRoleApiController
#374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7bc8497 to
0ee2cbb
Compare
OAuth2SpeakerOrganizationalRoleApiController
21a81d7 to
4a38e3c
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add security: [['summit_rsvp_oauth2' => [...]]] parameter
- Remove "Public endpoint accessible without authentication" from description
This endpoint requires OAuth2 authentication with ReadSummitData or ReadAllSummitData scope, it extents OAuth2ProtectedController.
@caseylocker thanks! all the changes are now implemented. |
444ac99 to
fd34d49
Compare
6c1ec6f to
eed533d
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo This looks good. @smarcet, if you agree please merge.
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@matiasperrone please resolve conflicts |
…uth2SpeakerOrganizationalRoleApiController.php
38a4325 to
b01de04
Compare
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task:
Ref: https://app.clickup.com/t/86b6wkgzf