Feature | Extend Swagger Coverage for controller OAuth2SpeakerActiveInvolvementApiController
#373
+98
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarcet
force-pushed
the
main
branch
5 times, most recently
from
c94fc68 to
9a8387b
Compare
matiasperrone-exo
added
the
documentation
matiasperrone-exo
changed the title
matiasperrone-exo
changed the title
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2speakeractiveinvolvementapicontroller
branch
from
bda14d6 to
66c89ea
Compare
matiasperrone-exo
changed the title
OAuth2SpeakerActiveInvolvementApiController
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2speakeractiveinvolvementapicontroller
branch
from
6cfb09e to
3689ca1
Compare
caseylocker
requested changes
Oct 30, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
- Add security: [["Bearer" => []]] parameter (this is NOT a public endpoint)
- Remove "Public endpoint accessible without authentication" from description (it requires OAuth2 authentication with ReadSummitData/ReadAllSummitData scope)
The endpoint extends OAuth2ProtectedController and requires authentication.
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2speakeractiveinvolvementapicontroller
branch
from
6e5d409 to
a2e1e2a
Compare
Contributor
Author
|
@caseylocker Thanks! I added a new security schema with the right information
@caseylocker Thanks! I added a new security schema with the right information |
…uth2SpeakerActiveInvolvementApiController.php
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2speakeractiveinvolvementapicontroller
branch
from
b7e8a15 to
f45a48e
Compare
Contributor
Author
|
@caseylocker @smarcet the security scope was fixed as requested. |
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2speakeractiveinvolvementapicontroller
branch
from
e93b59e to
32ffd0b
Compare
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2speakeractiveinvolvementapicontroller
branch
from
32ffd0b to
8a85d09
Compare
caseylocker
requested changes
Nov 21, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone REpeating here - This is an Oauth2 enpoint. Not public. Please remove "Public endpoint accessible without authentication." from the description.
Also, your expand parameter example is empty. If it has expandables please give examples. If it doesn't please remove or change to "description: 'No expandable relationships available for this resource'".
Once those are taken care of this should be good to go.
caseylocker
approved these changes
Nov 28, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
@smarcet This looks good. Please merge if you agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkgzc