Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo commented Sep 30, 2025

Task:

Ref: https://app.clickup.com/t/86b6wkfkv

Depends on PR #357

@matiasperrone-exo matiasperrone-exo self-assigned this Sep 30, 2025
@smarcet smarcet force-pushed the main branch 3 times, most recently from 2acb44b to 131872c Compare September 30, 2025 14:38
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller App\Http\Controllers\Apis\LanguagesApiController.php Feature | Extend Swagger Coverage for controller Apis/LanguagesApiController.php Sep 30, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller-languagesapicontroller branch from 813f722 to 3694a4f Compare September 30, 2025 16:01
@matiasperrone-exo matiasperrone-exo marked this pull request as ready for review September 30, 2025 17:37
@smarcet smarcet force-pushed the main branch 3 times, most recently from e3e142a to 161d4d3 Compare October 1, 2025 02:13
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo please review comments

@matiasperrone-exo matiasperrone-exo marked this pull request as draft October 1, 2025 18:16
@matiasperrone-exo
Copy link
Contributor Author

@smarcet all the requested changes were made, but it need PR #357 to be merged first

@smarcet smarcet force-pushed the main branch 7 times, most recently from c94fc68 to 9a8387b Compare October 2, 2025 17:58
@matiasperrone-exo matiasperrone-exo marked this pull request as ready for review October 6, 2025 22:13
@matiasperrone-exo
Copy link
Contributor Author

@smarcet As discussed, the generic schemas will be living in the main schemas.php file.
Please approve this PR. thank you

@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 7, 2025
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller Apis/LanguagesApiController.php Feature | Extend Swagger Coverage for controller LanguagesApiController Oct 13, 2025
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@smarcet smarcet force-pushed the feature/add-openapi-documentation-to-controller-languagesapicontroller branch from b3808e8 to 7e56225 Compare November 14, 2025 15:49
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 2dc8cf0 into main Nov 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation review Need reviewing from the developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants