Feature/opentelemetry middleware refactor #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarcet
reviewed
Sep 24, 2025
andrestejerina97
force-pushed
the
feature/opentelemetry-middleware-refactor
branch
from
9f69f85 to
c349aff
Compare
smarcet
requested changes
Sep 24, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
smarcet
reviewed
Sep 24, 2025
andrestejerina97
force-pushed
the
feature/opentelemetry-middleware-refactor
branch
from
c349aff to
f5ab4d2
Compare
andrestejerina97
force-pushed
the
feature/opentelemetry-middleware-refactor
branch
from
f5ab4d2 to
011d982
Compare
… available before logging
smarcet
reviewed
Sep 26, 2025
.env.example
Outdated
| #Open Telemetry | ||
| OTEL_SERVICE_ENABLED=true | ||
| OTEL_SERVICE_NAME=summit-api | ||
| OTEL_PROPAGATORS=tracecontext |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 this need to add baggage too
smarcet
reviewed
Sep 26, 2025
| { | ||
| $this->logger = $logger; | ||
| $this->shouldTrack = env('APP_ENV') !== 'testing' && | ||
| config('opentelemetry.enhance_requests', true); |
Collaborator
There was a problem hiding this comment.
this should be using the same feature flag as here
Line 176 in 6e5dc66
smarcet
reviewed
Sep 26, 2025
| } catch (\Throwable $e) { | ||
| // forcing 'single' channel in case otlp log fails | ||
| $this->logger->channel('single')->error("Error on request tracking" . $e->getMessage()); | ||
| $this->logger->channel('single')->error("Error on request tracking: " . $e->getMessage()); |
Collaborator
There was a problem hiding this comment.
this channel single logs to laravel.log we need a to change to daily
andrestejerina97
force-pushed
the
feature/opentelemetry-middleware-refactor
branch
from
676163e to
d2b4981
Compare
smarcet
force-pushed
the
main
branch
3 times, most recently
from
baa6699 to
a1e87f3
Compare
smarcet
force-pushed
the
main
branch
7 times, most recently
from
e3e142a to
161d4d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6r272w