Skip to content

Fix: remove components translations#234

Open
santipalenque wants to merge 2 commits intomainfrom
fix/remove-components-translations
Open

Fix: remove components translations#234
santipalenque wants to merge 2 commits intomainfrom
fix/remove-components-translations

Conversation

@santipalenque
Copy link
Copy Markdown
Contributor

@santipalenque santipalenque commented May 5, 2026

https://app.clickup.com/t/86b9ry738

The setTexts in barrel export /components/index.js creates a conflict with host app setTexts and overrides the translations when lazy loading.

in order to merge the two translation files (host app + uicore) we should use setAppTexts provided by uicore

Summary by CodeRabbit

  • Chores

    • Version updated to 5.0.18-beta.1
  • Refactor

    • Streamlined component module initialization by removing setup operations at import time.

@santipalenque santipalenque requested a review from smarcet May 5, 2026 20:20
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c78873e-664c-418a-a0ff-b131f7d3acee

📥 Commits

Reviewing files that changed from the base of the PR and between 61be5aa and 8cefc95.

📒 Files selected for processing (2)
  • package.json
  • src/components/index.js
💤 Files with no reviewable changes (1)
  • src/components/index.js

📝 Walkthrough

Walkthrough

Version updated to 5.0.18-beta.1 and i18n initialization code removed from the components barrel index file. The module now functions as a simple re-export without performing translation setup at import time.

Changes

Version Bump & Component Barrel Cleanup

Layer / File(s) Summary
i18n Setup Removal
src/components/index.js
Removed imports of React, i18n-react, and getCurrentUserLanguage, and deleted language detection and translation initialization logic that invoked T.setTexts().
Package Metadata
package.json
Version incremented from 5.0.16 to 5.0.18-beta.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • smarcet

Poem

🐰 A version hops forward, beta bound,
I18n setup files won't be found,
The barrel stands clean, trim and neat,
No translations loading at boot's heartbeat,
One small hop makes the codebase complete! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix: remove components translations' accurately summarizes the main change: removing translation setup code from the components barrel file to fix translation conflicts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-components-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant