Fix: remove components translations#234
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughVersion updated to 5.0.18-beta.1 and i18n initialization code removed from the components barrel index file. The module now functions as a simple re-export without performing translation setup at import time. ChangesVersion Bump & Component Barrel Cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
https://app.clickup.com/t/86b9ry738
The setTexts in barrel export /components/index.js creates a conflict with host app setTexts and overrides the translations when lazy loading.
in order to merge the two translation files (host app + uicore) we should use setAppTexts provided by uicore
Summary by CodeRabbit
Chores
Refactor