Skip to content

Fix MakieExt and ControlPlotsExt define VortexStepMethod.plot_geometry for the same type#237

Merged
ufechner7 merged 10 commits into
mainfrom
fix_ext
May 21, 2026
Merged

Fix MakieExt and ControlPlotsExt define VortexStepMethod.plot_geometry for the same type#237
ufechner7 merged 10 commits into
mainfrom
fix_ext

Conversation

@ufechner7
Copy link
Copy Markdown
Member

Fixes #236

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves the method redefinition/precompilation conflict when both Makie and ControlPlots are loaded by introducing an explicit plotting-backend dispatch layer in VortexStepMethod.plot_* APIs (Fixes #236).

Changes:

  • Added PlotBackend dispatch types plus set_plot_backend! and wrapper methods that route plotting calls through an active backend.
  • Updated Makie and ControlPlots extensions to implement plotting methods with an additional backend-dispatch argument.
  • Initialized a default active backend from each extension on load.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/VortexStepMethod.jl Introduces backend dispatch types, backend selection state, and wrapper routing for plotting entry points.
ext/VortexStepMethodMakieExt.jl Moves Makie plotting methods onto backend-dispatched signatures and sets Makie as the default backend on extension init.
ext/VortexStepMethodControlPlotsExt.jl Moves ControlPlots plotting methods onto backend-dispatched signatures and sets ControlPlots as the default backend on extension init.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ext/VortexStepMethodMakieExt.jl Outdated
Comment thread ext/VortexStepMethodControlPlotsExt.jl Outdated
Comment thread ext/VortexStepMethodMakieExt.jl
Comment thread ext/VortexStepMethodControlPlotsExt.jl
Comment thread ext/VortexStepMethodControlPlotsExt.jl Outdated
Comment thread src/VortexStepMethod.jl
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/VortexStepMethodControlPlotsExt.jl 40.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ufechner7 ufechner7 merged commit 51a8063 into main May 21, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MakieExt and ControlPlotsExt define VortexStepMethod.plot_geometry for the same type

2 participants