Permission poll progress#316
Open
ostcar wants to merge 3 commits intoOpenSlides:mainfrom
Open
Conversation
- Move poll.can_manage_pools to agenda_item - Move can_see_progress to each collection
Member
Author
|
@rrenkert ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a refactor of the poll permissions.
For a better diff, see: b1caa74
The old system used the permission poll.can_manage only for topic-polls. This proposal renames this to
agenda_item.can_manage_pollswhat is more clear.The old system used poll.can_see_progress for topic, motion and assignment polls. This means, that it was not possible to give a user only the permission for one of the collections. If we make a distinction for
can_manage_poolswe should also make a distinction forcan_see_progress.The old system has to problem, that if a user has the permission to create topic polls (poll.can_manage), he also gets the permission to see the progress bar for motion or assignment polls. This was probably not intended.
If you want, we can keep the old system for now, and I only change the permissions on the new-vote-service-branch