Fix fuzzy match participants and accounts#5865
Open
Borreg0 wants to merge 1 commit intoOpenSlides:mainfrom
Open
Fix fuzzy match participants and accounts#5865Borreg0 wants to merge 1 commit intoOpenSlides:mainfrom
Borreg0 wants to merge 1 commit intoOpenSlides:mainfrom
Conversation
bastianjoel
requested changes
Mar 13, 2026
Member
There was a problem hiding this comment.
Besides from the comments I think your changes are quite far away from fitting the requirements.
As far as I can see you also only do the normalization just one sided which means that when providing an input with special chars you won't be able to find such entries.
| if (this.isIncludedInProperty(item, trimmedInput, this.alsoFilterByProperties)) { | ||
| if ( | ||
| this.isIncludedInProperty(item, trimmedInput, this.alsoFilterByProperties) || | ||
| this.isIncludedInProperty(item, trimmedInput, this.filterProps) |
Member
There was a problem hiding this comment.
This should not be added here
| super( | ||
| [`short_name`, `username`, `email`, `saml_id`, `member_number`, `externalString`, `homeCommitteeName`], | ||
| [] | ||
| [`first_name`] |
Member
There was a problem hiding this comment.
I don't think it makes sense to put this here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2601